-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HSEARCH-3395 Make the .reference() and .object() projections type-safe in the Projection DSL #1788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 12
Including the following issue(s) which could not be reported in line:
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Remove this unused private "getSingleAccess" method. (more)
157c959
to
06b6eea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 11
Including the following issue(s) which could not be reported in line:
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for the CI feedback but as far AFAICS the changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 11
Including the following issue(s) which could not be reported in line:
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Remove this unused "singleAccess" private field. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
06b6eea
to
a67b443
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 11
Including the following issue(s) which could not be reported in line:
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Remove this unused "singleAccess" private field. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
28fb6f0
to
a7c9ee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 10
Including the following issue(s) which could not be reported in line:
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
- Code Smell: Complete the task associated to this TODO comment. (more)
public interface JavaBeanSearchManagerBuilder extends PojoSearchManagerBuilder<PojoSearchManager> { | ||
public interface JavaBeanSearchManagerBuilder { | ||
|
||
// TODO other options (default query timeout, default query hints, ...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Smell: Complete the task associated to this TODO comment. (squid:S1135)
@@ -15,8 +15,8 @@ | |||
/** | |||
* @author Yoann Rodiere | |||
*/ | |||
public interface HibernateOrmSearchQueryResultDefinitionContext<O> | |||
extends org.hibernate.search.mapper.orm.jpa.HibernateOrmSearchQueryResultDefinitionContext<O> { | |||
public interface FullTextQueryResultDefinitionContext<O> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Smell: Rename this interface. (squid:S2176)
@@ -15,7 +15,7 @@ | |||
/** | |||
* @author Yoann Rodiere | |||
*/ | |||
public interface HibernateOrmSearchQueryResultDefinitionContext<O> { | |||
public interface FullTextQueryResultDefinitionContext<O> { | |||
|
|||
// TODO add object loading options: ObjectLookupMethod, DatabaseRetrievalMethod, ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Smell: Complete the task associated to this TODO comment. (squid:S1135)
public interface SearchManagerBuilder<T extends SearchManager> { | ||
|
||
// TODO other options (default query timeout, query hints, ...) | ||
// TODO other options (default query timeout, default query hints, ...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Smell: Complete the task associated to this TODO comment. (squid:S1135)
…ded objects when we create a SearchTarget This is necessary if we want to create typed projections to references and loaded objects (see following commits).
…e in the Projection DSL
a7c9ee5
to
8ebe33d
Compare
Merged, thanks! |
https://hibernate.atlassian.net//browse/HSEARCH-3395
Based on #1787 , which should be merged first.